Skip to content

Conversation

@antoniojbt
Copy link
Owner

What was changed and why

  • replace legacy parallel plotting script with exported epi_plot_parallel() and epi_plot_save_parallel()
  • document new helpers and add foreach import
  • cover parallel plotting with tests

Tests added

  • tests/testthat/test-plot-parallel.R

Backward compatibility

  • No breaking changes intended

Code coverage change

  • No significant change reported

https://chatgpt.com/codex/tasks/task_e_68ade63b44b08326a8daa1ff1c75a828

Copilot AI review requested due to automatic review settings August 27, 2025 18:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds new parallel plotting utilities to replace legacy code with properly exported functions. The change transforms an internal script into two documented, tested functions for parallel plot generation and saving.

Key changes:

  • Added epi_plot_parallel() and epi_plot_save_parallel() functions with full documentation
  • Moved foreach from suggested to required dependencies
  • Added comprehensive test coverage for parallel plotting functionality

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
R/epi_plot_parallel.R New implementation of parallel plotting functions with proper error handling and documentation
tests/testthat/test-plot-parallel.R Test suite covering both parallel plotting functions with multicore execution
man/epi_plot_parallel.Rd Generated documentation for the new parallel plotting functions
legacy/epi_plot_en_masse.R Removal of legacy parallel plotting script
NAMESPACE Updated exports and imports including new foreach import
DESCRIPTION Moved foreach from Suggests to Imports section

@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 67.39130% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.54%. Comparing base (02d0a41) to head (e3075e6).

Files with missing lines Patch % Lines
R/epi_plot_parallel.R 67.39% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   84.82%   85.54%   +0.71%     
==========================================
  Files          61       62       +1     
  Lines        1351     1397      +46     
==========================================
+ Hits         1146     1195      +49     
+ Misses        205      202       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…gement-in-epi_utils_multicore

Codex/adjust future plan management in epi utils multicore
@antoniojbt antoniojbt closed this Aug 29, 2025
@antoniojbt antoniojbt deleted the codex/remove-file-and-add-parallel-plot-functions branch August 29, 2025 21:16
@antoniojbt antoniojbt restored the codex/remove-file-and-add-parallel-plot-functions branch August 29, 2025 21:25
@antoniojbt antoniojbt reopened this Aug 29, 2025
@antoniojbt antoniojbt closed this pull request by merging all changes into master in 2d50ee8 Aug 29, 2025
@antoniojbt antoniojbt deleted the codex/remove-file-and-add-parallel-plot-functions branch August 29, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants