[ Fix ]: Allow dynamic ExternalIPPool IP range update when no IPs are allocated #7532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e allocated Signed-off-by: codeEvolveZenith345 <[email protected]>
codeEvolveZenith345
force-pushed
the
allow-dynamic-externalippool-iprange-update
branch
from
a3b8c0a to
bfdc264
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable dynamic update and shrinking of ExternalIPPool IP ranges when no IP addresses have been allocated from the pool. Previously, the webhook blocked modifications even in the absence of allocations. This change checks usage and allows the operation if safe.
Fixes: #7143
Component: pkg/controller/externalippool/validate.go