migrate to events.event #7613
Open
migrate to events.event #7613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartikangiras
force-pushed
the
migrateevents
branch
from
09ea640 to
62c2dc6
Compare
Author
|
@antoninbas PTAL |
antoninbas
reviewed
Dec 8, 2025
Contributor
antoninbas
left a comment
antoninbas
left a comment
There was a problem hiding this comment.
Thanks for the PR - please take a look at test/e2e/egress_test.go, we use the core API for events there and I think it should be replaced as part of this change?
kartikangiras
force-pushed
the
migrateevents
branch
2 times, most recently
from
08f18c9 to
2529a70
Compare
Author
|
@antoninbas i have made the necessary changes requested |
antoninbas
reviewed
Dec 19, 2025
kartikangiras
force-pushed
the
migrateevents
branch
2 times, most recently
from
8f87d55 to
2f44e86
Compare
Author
|
@antoninbas resolved the changes you asked for, thanks. |
Contributor
|
@kartikangiras The e2e tests ( |
luolanzone
reviewed
Dec 24, 2025
update parameters Signed-off-by: Kartik Angiras <[email protected]>
Signed-off-by: Kartik Angiras <[email protected]>
Signed-off-by: Kartik Angiras <[email protected]>
Signed-off-by: Kartik Angiras <[email protected]>
Signed-off-by: Kartik Angiras <[email protected]>
kartikangiras
force-pushed
the
migrateevents
branch
from
ea6827c to
b723dea
Compare
Author
|
i have tested the changes locally they are working fine, i do not know why the e2e ci checks are failing. |
|
@antoninbas I have been seeing many PRs with failing e2e ci, so maybe the failure is not be due to the PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7525