-
Notifications
You must be signed in to change notification settings - Fork 649
docs: 更新饼图&图例官网例子 #2134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: 更新饼图&图例官网例子 #2134
Conversation
Summary of ChangesHello @tangying1027, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 本次拉取请求主要更新了 AntV F2 图表库的文档和示例。核心目的是增强图例组件的展示和说明,特别是新增了图例布局的示例,并对现有的饼图示例进行了优化和调整,使其更清晰、更符合实际使用场景。此外,还对部分文档标题进行了精简。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
本次 PR 主要更新了饼图和图例的官网文档和示例。代码审查发现了一些可以改进的地方:
- 新增的图例布局示例 (
layoutMode.jsx) 中包含未使用的冗余数据属性,建议移除以保持代码整洁。 - 图例的文档 (
index.zh.md) 中有两处描述不一致或不准确的地方,可能会误导用户,建议进行修正以提高文档质量。
其他关于饼图示例的修改主要是视觉调整和功能增强(如增加spider类型的标签),看起来没有问题。
| { genre: '债券基金', sold: 275, a: '1' }, | ||
| { genre: '申万宏源固守+基金指数', sold: 115, a: '1' }, | ||
| { genre: '基金指数', sold: 120, a: '1' }, | ||
| { genre: '股票基金', sold: 300, a: '1' }, | ||
| { genre: '混合基金', sold: 180, a: '1' }, | ||
| { genre: '货币基金', sold: 90, a: '1' }, | ||
| { genre: 'QDII基金', sold: 60, a: '1' }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
示例数据 multiLineData 中的 a: '1' 属性在 <Interval /> 组件中并未使用。为了保持示例代码的简洁和清晰,建议移除这个未使用的属性。
| { genre: '债券基金', sold: 275, a: '1' }, | |
| { genre: '申万宏源固守+基金指数', sold: 115, a: '1' }, | |
| { genre: '基金指数', sold: 120, a: '1' }, | |
| { genre: '股票基金', sold: 300, a: '1' }, | |
| { genre: '混合基金', sold: 180, a: '1' }, | |
| { genre: '货币基金', sold: 90, a: '1' }, | |
| { genre: 'QDII基金', sold: 60, a: '1' }, | |
| { genre: '债券基金', sold: 275 }, | |
| { genre: '申万宏源固守+基金指数', sold: 115 }, | |
| { genre: '基金指数', sold: 120 }, | |
| { genre: '股票基金', sold: 300 }, | |
| { genre: '混合基金', sold: 180 }, | |
| { genre: '货币基金', sold: 90 }, | |
| { genre: 'QDII基金', sold: 60 }, |
|
|
||
| ### 布局方式 | ||
|
|
||
| - [基础图例](./demo/legend.jsx):展示基本的图例组件。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| - [自定义图例](./demo/custom.jsx):自定义样式和布局的图例。 | ||
| - [可交互图例](./demo/interactive.jsx):支持点击交互的图例组件。 | ||
| - [可交互图例](./demo/layoutMode.jsx):两种布局方式。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: |
Checklist
npm testpassesDescription of change