Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 在建议的开发环境下重新生成pnpm-lock.yml #361

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

tyn1998
Copy link
Collaborator

@tyn1998 tyn1998 commented Jun 14, 2023

👀 PR includes

✨ Feature

  • New feature

🎨 Enhance

  • Code style optimization
  • Refactoring
  • Change the UI
  • Improve the performance
  • Type optimization

🐛 Bugfix

  • Solve the issue and close #0

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other (build)

📝 Description

#355 后,协作者们的开发环境应该统一(i.e. Node 16 & pnpm 8)了,于是pnpm-lock.yml文件应该尽量保持不动,所以我在本地先删除了该文件,并运行pnpm i重新生成。

以我有限的经验来说,lock文件是不应该经常变动的,之前总是能在proposed changes里看到它的身影,应该是协作者之间的开发环境不统一导致。除了影响开发体验外,1.75MB的pnpm-lock.yml还因为经常被提交到commit中生成了许多blob文件,增加了Git仓库的体积,加长了初次clone、日常fetch和push的时间(在网络环境欠佳的时候尤其明显)。

这个PR希望能终结pnpm-lock.yml频繁改动的现象。希望各位协作者能在本地试试看:

  1. gh pr checkout 361
  2. 确保本地开发环境是 Node 16 和 pnpm 8(请看这个分支下的README)
  3. pnpm install --force(等价于先删除node_modulespnpm install
  4. pnpm run start

然后确认两件事:(1) pnpm-lock.yml有没有被改动;(2)项目能不能跑起来。

@andyhuang18 @wj23027 @pomelo-nwu @yangzy0603 @Yanyan-Wang

🔗 Related issue link

N.A.

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@tyn1998
Copy link
Collaborator Author

tyn1998 commented Jun 14, 2023

@andyhuang18 @wj23027 两位同学看看在这个分支下依赖能不能安装成功,并且成功跑起来。具体操作见Description~

Copy link
Member

@pomelo-nwu pomelo-nwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pomelo-nwu pomelo-nwu merged commit d0bd258 into antvis:master Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants