Skip to content

Conversation

@GeoDaoyu
Copy link
Contributor

@GeoDaoyu GeoDaoyu commented Jul 9, 2025

[English Template / 英文模板]

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 工作流程
  • 版本更新
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

#2734

💡 需求背景和解决方案

之前不知道如何导入子包的类,所以copy了一份代码到l7-map,现在从@antv/l7-maps导入类。

📝 更新日志

语言 更新描述
🇺🇸 英文
🇨🇳 中文

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2025

⚠️ No Changeset found

Latest commit: 94fd98a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@petercat-assistant
Copy link

Walkthrough

此PR重构了SimpleMapCoord类的导入方式,从本地复制的代码改为从@antv/l7-maps包中导入。这一变动旨在减少代码重复并提高模块化。

Changes

文件 概要
packages/map/src/map/events.ts SimpleMapCoord的导入路径从本地更改为@antv/l7-maps
packages/map/src/map/util/simpleMapCoord.ts 删除了本地定义的SimpleMapCoord类及其接口。
packages/maps/src/utils/index.ts 更新导出,新增从simpleMapCoord导入的SimpleMapCoord

import Point from '@mapbox/point-geometry';
import { DOM } from './util/dom';

import { SimpleMapCoord } from '@antv/l7-maps';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确保从@antv/l7-maps导入的SimpleMapCoord类与原本实现的功能一致,以避免潜在的功能性问题。

@GeoDaoyu
Copy link
Contributor Author

lzxue:不能在map 组件导入 antv/l7-maps,这样会有循环引用,反之是可以的。

@GeoDaoyu GeoDaoyu closed this Jul 16, 2025
@GeoDaoyu GeoDaoyu deleted the fix/SimpleMapCoord branch July 16, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant