- 
                Notifications
    
You must be signed in to change notification settings  - Fork 48
 
feat: standardize the className of the axis #362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
          Summary of ChangesHello @interstellarmt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant improvement in the maintainability and customizability of UI components by standardizing their CSS class names. By allowing a configurable prefix, it provides greater flexibility for integration into diverse styling environments and reduces potential class name conflicts. This change affects both axis and legend components, ensuring a consistent approach to styling across these critical charting elements. Highlights
 Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either  
 Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a  Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully standardizes class names for axis and legend components by introducing a classNamePrefix. The changes are well-structured, with new logic encapsulated in src/ui/axis/utils/classname.ts, which improves consistency and makes components easier to style. I've provided a few suggestions to refactor some of the new logic for improved readability and maintainability. Overall, this is a solid contribution that enhances the library's styling capabilities.
standardize the className of the axis
[Axis2] className: "axis g2-axis"
├── [Group2] className: "axis-grid-group g2-axis-grid-group"
│ └── [Grid2] className: "axis-grid g2-axis-grid"
├── [Group2] className: "axis-main-group g2-axis-main-group"
│ ├── [Group2] className: "axis-line-group g2-axis-line-group"
│ │ └── [Line2] className: "axis-line g2-axis-line"
│ ├── [Group2] className: "axis-tick-group g2-axis-tick-group"
│ │ ├── [Group2] className: "axis-tick g2-axis-tick"
│ │ │ └── [Line2] className: "axis-tick-item g2-axis-tick-item"
│ │ ├── [Group2] className: "axis-tick g2-axis-tick"
│ │ │ └── [Line2] className: "axis-tick-item g2-axis-tick-item"
│ │ ├── [Group2] className: "axis-tick g2-axis-tick"
│ │ │ └── [Line2] className: "axis-tick-item g2-axis-tick-item"
│ │ ├── [Group2] className: "axis-tick g2-axis-tick"
│ │ │ └── [Line2] className: "axis-tick-item g2-axis-tick-item"
│ │ ├── [Group2] className: "axis-tick g2-axis-tick"
│ │ │ └── [Line2] className: "axis-tick-item g2-axis-tick-item"
│ │ └── [Group2] className: "axis-tick g2-axis-tick"
│ │ └── [Line2] className: "axis-tick-item g2-axis-tick-item"
│ └── [Group2] className: "axis-label-group g2-axis-label-group"
│ ├── [Group2] className: "axis-label g2-axis-label"
│ │ └── [Text3] className: "axis-label-item g2-axis-label-item"
│ ├── [Group2] className: "axis-label g2-axis-label"
│ │ └── [Text3] className: "axis-label-item g2-axis-label-item"
│ ├── [Group2] className: "axis-label g2-axis-label"
│ │ └── [Text3] className: "axis-label-item g2-axis-label-item"
│ ├── [Group2] className: "axis-label g2-axis-label"
│ │ └── [Text3] className: "axis-label-item g2-axis-label-item"
│ ├── [Group2] className: "axis-label g2-axis-label"
│ │ └── [Text3] className: "axis-label-item g2-axis-label-item"
│ └── [Group2] className: "axis-label g2-axis-label"
│ └── [Text3] className: "axis-label-item g2-axis-label-item"
└── [Group2] className: "axis-title-group g2-axis-title-group"
└── [Text3] className: "axis-title g2-axis-title"