chore: code optimization - #2
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase by making the vector store search asynchronous, simplifying the TransformerVectorizer initialization, moving the Loader interface to types, and introducing a centralized generateDocId helper. Feedback on the changes highlights potential ID collisions when using only the file basename for document IDs, the risk of runtime errors from non-null assertions when retrieving documents during queries, and the recommendation to retain the close() method in ZVecStore to properly release file locks in tests.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
searchHybridSyncdead code清理loader