test: add testcases and coverage - #4
Conversation
There was a problem hiding this comment.
Code Review
This pull request significantly expands test coverage across multiple modules (including the embedder, expander, loaders, reranker, storage, and utilities) and reorganizes utility functions, such as moving containsCJK to the tokenizer module. The reviewer feedback highlights several important improvements: cleaning up temporary directories in test/context.test.ts to prevent workspace clutter, reordering setup steps in test/storage/store.test.ts to avoid test instability, using cross-platform paths instead of hardcoded absolute paths in test/utils/sample.test.ts, and correcting the documented type of queryExpansion in the README to match its actual implementation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
The failures were caused by two issues:
Commit: fix: increase test timeouts and prevent concurrent model downloads in CI |
96%+.HF_ENDPOINTtip