mcp register#237
Conversation
Summary of ChangesHello @XinyueDu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the foundational configuration for the Model Context Protocol (MCP) server responsible for AntV chart generation. It establishes the server's identity and operational parameters through a dedicated configuration file, ensuring proper registration and versioning within the MCP ecosystem. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces MCP registration configuration by adding a server.json file and updating package.json. The changes are well-structured and align with the goal of registering the server with the Model Context Protocol. My feedback includes a couple of suggestions to improve the clarity of environment variable descriptions in server.json to enhance user experience and prevent configuration issues.
There was a problem hiding this comment.
Pull request overview
This PR adds MCP (Model Context Protocol) registry configuration to enable the package to be published to the MCP registry. The changes include registry metadata configuration, package version updates, and an automated workflow for publishing to the MCP registry.
- Added server.json with MCP registry metadata and environment variable documentation
- Updated package.json with mcpName field and version bump from 0.9.5 to 0.9.6
- Added GitHub Actions workflow to automatically publish to MCP registry on tag pushes
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| server.json | New MCP registry configuration file defining package metadata, repository info, and three environment variables (VIS_REQUEST_SERVER, SERVICE_ID, DISABLED_TOOLS) |
| package.json | Added mcpName field "io.github.antvis/mcp-server-chart" and bumped version to 0.9.6 |
| .github/workflows/release.yml | New workflow to build, update version placeholders, and publish to MCP registry on tag creation using OIDC authentication |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Renamed job from 'build-and-publish' to 'publish-to-mcp-registry' and removed the build step.
add mcp register config
发布后网站:https://registry.modelcontextprotocol.io/
发布后的资产:
https://registry.modelcontextprotocol.io/v0.1/servers/io.github.antvis%2Fmcp-server-chart/versions/0.9.6