Skip to content

mcp register#237

Merged
hustcc merged 4 commits into
mainfrom
dev/mcp-register
Dec 4, 2025
Merged

mcp register#237
hustcc merged 4 commits into
mainfrom
dev/mcp-register

Conversation

@XinyueDu
Copy link
Copy Markdown
Contributor

@XinyueDu XinyueDu commented Dec 4, 2025

Copilot AI review requested due to automatic review settings December 4, 2025 03:46
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @XinyueDu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the foundational configuration for the Model Context Protocol (MCP) server responsible for AntV chart generation. It establishes the server's identity and operational parameters through a dedicated configuration file, ensuring proper registration and versioning within the MCP ecosystem.

Highlights

  • MCP Server Configuration: A new configuration file, server.json, has been added to define the Model Context Protocol (MCP) server's metadata, package details, and environment variables for chart generation.
  • Package Metadata Update: The package.json file has been updated to include an mcpName field and increment the package version from 0.9.5 to 0.9.6.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/release.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces MCP registration configuration by adding a server.json file and updating package.json. The changes are well-structured and align with the goal of registering the server with the Model Context Protocol. My feedback includes a couple of suggestions to improve the clarity of environment variable descriptions in server.json to enhance user experience and prevent configuration issues.

Comment thread server.json Outdated
Comment thread server.json Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds MCP (Model Context Protocol) registry configuration to enable the package to be published to the MCP registry. The changes include registry metadata configuration, package version updates, and an automated workflow for publishing to the MCP registry.

  • Added server.json with MCP registry metadata and environment variable documentation
  • Updated package.json with mcpName field and version bump from 0.9.5 to 0.9.6
  • Added GitHub Actions workflow to automatically publish to MCP registry on tag pushes

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
server.json New MCP registry configuration file defining package metadata, repository info, and three environment variables (VIS_REQUEST_SERVER, SERVICE_ID, DISABLED_TOOLS)
package.json Added mcpName field "io.github.antvis/mcp-server-chart" and bumped version to 0.9.6
.github/workflows/release.yml New workflow to build, update version placeholders, and publish to MCP registry on tag creation using OIDC authentication

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml Outdated
duxinyue.dxy and others added 2 commits December 4, 2025 15:42
Renamed job from 'build-and-publish' to 'publish-to-mcp-registry' and removed the build step.
@hustcc hustcc merged commit 09d0481 into main Dec 4, 2025
1 check passed
@hustcc hustcc deleted the dev/mcp-register branch December 4, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants