Notify users when linux-wallpaperengine exits immediately#289
Open
louzt wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split from #279 to keep the first user-visible fix small and easy to review.
This changes the
linux-wallpaperenginelaunch path from a shell-backgrounded command to an argvPopen()process that Waypaper can observe briefly after launch. If the renderer exits immediately, Waypaper now prints a clear message and sends a desktop notification whennotify-sendis available.Why
Silent
linux-wallpaperenginelaunch exits are hard to diagnose because the previous shell-backgrounded launch path discarded stdout/stderr and did not keep a process handle that Waypaper could check.This PR only surfaces the immediate failure to the user. It does not include the larger logging/refactor work from #279.
What changed
linux-wallpaperenginewith argvPopen()instead ofshell=Trueplus&.Validation
Result: 13 tests pass.
Follow-ups
The broader #279 branch still contains logging, fallback, process cleanup, and module-boundary hardening. Those can be rebased/split separately after this smaller piece is reviewed.