Fix linux-wallpaperengine noautomute config lookup#290
Conversation
|
I am not too sure about the tests. |
|
No worries! the unit test is just there as a safety guard to prevent this specific key lookup from regressing in future config updates imo bcs i love have test and spec drive over it on my wflws, but i agree could be large diff for minimalistics/cleaning final really final, at least trying to be final, final version to merge on this specific case scenario, which is ok cut test, on others could be better for work cleaner over other pending topics, but in this... imo, i could get rid of those if u want with git rm tests/test_config.py. No problem. If you prefer to keep the test suite lighter and just land the 1-line configuration fix, let me know and I can drop the test file right away. Completely up to you guys! Just did my best to make it robust, but I'm open to details. Or adapt like i said, on pending refactors on #279 over time. |
|
Yes, we typically don't carry all the tests, especially for something as simple as just adding a config parameter. |
Summary
Read
linux_wallpaperengine_noautomutefrom its own config key.Validation
python3 -m py_compile waypaper/config.pygit diff --check