Skip to content

Fix linux-wallpaperengine noautomute config lookup#290

Open
louzt wants to merge 2 commits into
anufrievroman:mainfrom
louzt:fix/linux-wallpaperengine-noautomute-typo
Open

Fix linux-wallpaperengine noautomute config lookup#290
louzt wants to merge 2 commits into
anufrievroman:mainfrom
louzt:fix/linux-wallpaperengine-noautomute-typo

Conversation

@louzt
Copy link
Copy Markdown
Contributor

@louzt louzt commented May 23, 2026

Summary

Read linux_wallpaperengine_noautomute from its own config key.

Validation

  • python3 -m py_compile waypaper/config.py
  • git diff --check

Comment thread waypaper/config.py
@Im-shamo
Copy link
Copy Markdown
Contributor

I am not too sure about the tests.
@anufrievroman, what do you think about it.

@louzt
Copy link
Copy Markdown
Contributor Author

louzt commented May 23, 2026

No worries! the unit test is just there as a safety guard to prevent this specific key lookup from regressing in future config updates imo bcs i love have test and spec drive over it on my wflws, but i agree could be large diff for minimalistics/cleaning final really final, at least trying to be final, final version to merge on this specific case scenario, which is ok cut test, on others could be better for work cleaner over other pending topics, but in this... imo, i could get rid of those if u want with git rm tests/test_config.py. No problem.

If you prefer to keep the test suite lighter and just land the 1-line configuration fix, let me know and I can drop the test file right away. Completely up to you guys! Just did my best to make it robust, but I'm open to details. Or adapt like i said, on pending refactors on #279 over time.

@anufrievroman
Copy link
Copy Markdown
Owner

Yes, we typically don't carry all the tests, especially for something as simple as just adding a config parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants