Tag-based SGP interaction - #309
Draft
K-Johnson-Horrigan wants to merge 12 commits into
Draft
Conversation
…gs to work with new code
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 77.07% 77.44% +0.37%
==========================================
Files 108 109 +1
Lines 23154 23211 +57
Branches 1615 1626 +11
==========================================
+ Hits 17845 17975 +130
+ Misses 5238 5165 -73
Partials 71 71 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
K-Johnson-Horrigan
marked this pull request as ready for review
July 13, 2026 19:23
| VALUE(TASK_PROFILE_COMPATIBILITY_MODE, std::string, "always", "How is compatibility determined for task profiles? always, task-any-match, task-perfect-match"), | ||
| VALUE(HORIZONTAL_TRANSMISSION_COMPATIBILITY_MODE, std::string, "always", "How is compatibility determined for horizontal transmission? Relies on TASK_PROFILE_COMPATIBILITY_MODE being set appropriately. Options are: always, task-profile-compatible, task-profile-strictly-stronger-match, task-profile-stronger-or-equal-match"), | ||
| VALUE(INTERACTION_PROFILE_COMPATIBILITY_MODE, std::string, "always", "How is compatibility determined for task profiles? always, task-any-match, task-perfect-match, tag-probabilistic-match"), | ||
| VALUE(HORIZONTAL_TRANSMISSION_COMPATIBILITY_MODE, std::string, "always", "How is compatibility determined for horizontal transmission? Relies on INTERACTION_PROFILE_COMPATIBILITY_MODE being set appropriately. Options are: always, task-profile-compatible, task-profile-strictly-stronger-match, task-profile-stronger-or-equal-match"), |
Owner
There was a problem hiding this comment.
Should the options change "interaction-profile-compatible" etc?
| } | ||
| } | ||
|
|
||
| void SGPWorld::SetupInteractionCompatibilityMode() { |
Owner
There was a problem hiding this comment.
More complete docstring needed
| return a == b; | ||
| }; | ||
| } else if(sgp_config.INTERACTION_PROFILE_COMPATIBILITY_MODE() == "tag-probabilistic-match"){ | ||
| fun_task_profile_compatibility_check = [this]( |
Owner
There was a problem hiding this comment.
This feels risky since it seems like we might use task_profile compatibility in some way even when the interaction is based on tags, which I guess would mean we want a separate config for task compatibility still
| @@ -26,8 +26,8 @@ EMP_EXTEND_CONFIG(SymConfigSGP, SymConfigBase, | |||
| VALUE(INTERACTION_MECHANISM, std::string, "default", "What sgp organisms should population the world? (Options: 'default')"), | |||
| VALUE(VT_TASK_MATCH, bool, false, "Should task matching be required for vertical transmission? (0 for no, 1 for yes)"), | |||
| VALUE(TASK_PROFILE_MODE, std::string, "self-all", "What should we use for task profiles for host-symbiont compatibility, preferential ousting, etc.? Options are parent-all, self-all, self-first, parent-first. 'all' means all tasks, 'first' means only first task performed."), | |||
Owner
There was a problem hiding this comment.
How does task_profile mode interact with interaction profile compatbility when it's tag based? I think we need to think about this system overall a bit more to try to make this intuitive, oof
K-Johnson-Horrigan
marked this pull request as draft
July 16, 2026 15:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames TASK_PROFILE_COMPATIBILITY_MODE to INTERACTION_PROFILE_COMPATIBILITY_MODE and implements a wrapper function that allows tags to be used for interaction. However, tags cannot be used for horizontal transmission, and thus the horizontal transmission settings automatically pass when tag matching is on in SGP. Maybe worth keeping both the old TASK_PROFILE_COMPATIBILITY_MODE option and the new INTERACTION_PROFILE_COMPATIBILITY_MODE option, for backcompatibility/task based horizontal transmission; however, that would contribute to config bloat.