Skip to content

Implement JSON features for ProgramBuilder - #310

Merged
anyaevostinar merged 12 commits into
anyaevostinar:mainfrom
mmore500:json
Jul 13, 2026
Merged

Implement JSON features for ProgramBuilder#310
anyaevostinar merged 12 commits into
anyaevostinar:mainfrom
mmore500:json

Conversation

@mmore500

@mmore500 mmore500 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@mmore500
mmore500 marked this pull request as draft July 7, 2026 15:52
mmore500 added 3 commits July 7, 2026 12:12
Add empty descriptors/categories to Inst template to allow JSON
serialization.

Tests drafted by @claude
@mmore500
mmore500 marked this pull request as ready for review July 7, 2026 21:34
Comment thread source/sgp_mode/hardware/Instructions.h
Comment thread source/sgp_mode/ProgramBuilder.h Outdated
Comment thread source/sgp_mode/ProgramBuilder.h

@anyaevostinar anyaevostinar left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for doing this! If possible, it'd be nice to get some of the doc strings in before pulling it in, but just let me know if you don't have time for them right now!

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.05%. Comparing base (c323dcd) to head (498ed14).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
+ Coverage   76.93%   77.05%   +0.11%     
==========================================
  Files         108      108              
  Lines       23013    23131     +118     
  Branches     1609     1611       +2     
==========================================
+ Hits        17706    17824     +118     
  Misses       5236     5236              
  Partials       71       71              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mmore500
mmore500 requested a review from anyaevostinar July 13, 2026 18:46
@mmore500

mmore500 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

Review comments look good and should be addressed! Also took advantage of the opportunity to add matching docstrings in touched areas. Some hand-written, and some generated with hand review/revision. Noted in commit messages.

@anyaevostinar anyaevostinar left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@anyaevostinar
anyaevostinar merged commit b34220c into anyaevostinar:main Jul 13, 2026
4 checks passed
@mmore500
mmore500 deleted the json branch July 13, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants