Skip to content

Fixed jumps and anchors in Genome Printing - #311

Merged
anyaevostinar merged 6 commits into
anyaevostinar:mainfrom
EliasH-E:jump-fix
Jul 14, 2026
Merged

Fixed jumps and anchors in Genome Printing#311
anyaevostinar merged 6 commits into
anyaevostinar:mainfrom
EliasH-E:jump-fix

Conversation

@EliasH-E

@EliasH-E EliasH-E commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Fixed error when genomes were printed that caused jump instructions to not have any information on where they jump was to
Fixed error when genomes were printed that caused anchors to be printed with large binary numbers

Comment thread source/sgp_mode/hardware/SGPHardware.h Outdated

@anyaevostinar anyaevostinar left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! One tiny removal and it's good to go

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.05%. Comparing base (498ed14) to head (ec1db9c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
source/sgp_mode/hardware/SGPHardware.h 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   77.05%   77.05%           
=======================================
  Files         108      108           
  Lines       23131    23131           
  Branches     1611     1611           
=======================================
  Hits        17824    17824           
  Misses       5236     5236           
  Partials       71       71           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anyaevostinar
anyaevostinar merged commit 97afabb into anyaevostinar:main Jul 14, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants