Adding Repro Rate Data Node - #322
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #322 +/- ##
==========================================
+ Coverage 77.09% 77.13% +0.03%
==========================================
Files 108 108
Lines 23155 23185 +30
Branches 1615 1619 +4
==========================================
+ Hits 17852 17883 +31
+ Misses 5232 5231 -1
Partials 71 71 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| emp::DataMonitor<int>& data_node_sym_repro_rate = my_world->GetSymReproRateDataNode(); | ||
| data_node_sym_repro_rate.AddDatum(1); | ||
| //Increase Data Repro Count by 1 |
| emp::DataMonitor<double, emp::data::Histogram>& GetHostedSymInfectChanceDataNode(); | ||
| emp::DataMonitor<double, emp::data::Histogram>& GetWithinHostMeanDataNode(); | ||
| emp::DataMonitor<double, emp::data::Histogram>& GetWithinHostVarianceDataNode(); | ||
| emp::DataMonitor<int>& GetHostReproRateDataNode(); |
There was a problem hiding this comment.
Why are there both Counts and Rates?
There was a problem hiding this comment.
Repro Count was/is the name for the lineage data node, and is not one that I created. GetHostReproCountDataNode in the data node file is what controls this data node though I do think that Lauren possibly renamed it?
| * Purpose: To set up the file that will be used to track the number | ||
| * of reproductions of both Hosts and Symbionts | ||
| */ | ||
| emp::DataFile & SymWorld::SetupReproRateFile(const std::string & filename) { |
There was a problem hiding this comment.
Should probably be "count" instead of rate, since it is just a raw count, not divided over time or anything
There was a problem hiding this comment.
I agree and would prefer to change the name to 'count' instead of rate though that name is currently being used by a different data node. I would be happy to change either of the data nodes names.
| } | ||
| } | ||
|
|
||
| TEST_CASE("ParseJsonString()", "[sgp][sgp-unit]"){ |
There was a problem hiding this comment.
Where did these go? Why are they being removed?
There was a problem hiding this comment.
I have absolutely no idea why these tests have been removed, this branch should not be editing any tests in this file. Will revert file since this seems to be the only change?
anyaevostinar
left a comment
anyaevostinar
left a comment
There was a problem hiding this comment.
Just a few things, but mainly repro "rate" doesn't seem quite accurate
2 participants
Adds Repro Rate Data Node
Removed Hosts & Syms Matching on World Creation
Changed Default SGP Mode settings to more useful defaults
Updated tests to reflect these changes