Skip to content

Point sub not set 0 - #326

Open
Gabe-Rose wants to merge 6 commits into
anyaevostinar:mainfrom
Gabe-Rose:Point_Sub_not_Set_0
Open

Point sub not set 0#326
Gabe-Rose wants to merge 6 commits into
anyaevostinar:mainfrom
Gabe-Rose:Point_Sub_not_Set_0

Conversation

@Gabe-Rose

Copy link
Copy Markdown
Contributor

Switching points to subtraction - and updating associated tests

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.10%. Comparing base (80c2445) to head (c2f6b83).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   77.09%   77.10%           
=======================================
  Files         108      108           
  Lines       23155    23162    +7     
  Branches     1615     1616    +1     
=======================================
+ Hits        17852    17859    +7     
  Misses       5232     5232           
  Partials       71       71           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

host_baby->Mutate();
host_baby->SetReproCount(reproductions + 1);
SetPoints(0);
this->AddPoints(-1 * my_config->HOST_REPRO_RES());

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need "this", just call AddPoints

// now set to 0 in symdobirth
if(!my_config->TAG_MATCHING() && !my_config->FREE_HT_FAILURE()) {
if (my_config->FREE_LIVING_SYMS() && my_host == nullptr && my_config->FREE_SYM_REPRO_RES() > -1) {
this->AddPoints(-1 * my_config->FREE_SYM_REPRO_RES());

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto on "this"

}

TEST_CASE("Process", "[default]") {
TEST_CASE("Process", "[default][Test]") {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Test tag

Comment thread web/symbulation.js

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file from the PR

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which you probably need to "restore" for, we need this for the web gui to work

@anyaevostinar anyaevostinar left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants