IOS-5681 Add /verify command #4462
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
.claude/commands/verify.md
Outdated
| ``` | ||
|
|
||
| 2. **If background (yes):** | ||
| - Use Task tool with `run_in_background: true` |
There was a problem hiding this comment.
Best Practices: Incorrect Task tool usage. The Task tool does not have a run_in_background parameter. Background execution should use the Bash tool with run_in_background: true parameter instead.
.claude/commands/verify.md
Outdated
| swiftlint lint --config .swiftlint.yml -- path/to/file1.swift path/to/file2.swift | ||
|
|
||
| # Or lint all changed files at once | ||
| git diff --name-only origin/develop...HEAD -- "*.swift" | xargs swiftlint lint --config .swiftlint.yml -- |
There was a problem hiding this comment.
Best Practices: Using xargs without handling spaces in file paths. Swift files with spaces in their names will break this command.
.claude/commands/verify.md
Outdated
| xcodebuild build \ | ||
| -workspace Anytype.xcworkspace \ | ||
| -scheme Anytype \ | ||
| -destination 'platform=iOS Simulator,name=iPhone 16' \ |
There was a problem hiding this comment.
Best Practices: Hardcoded device name iPhone 16 may not exist on all runner environments. Consider using a more widely available simulator like iPhone 15.
Best Practices.claude/commands/verify.md:66 .claude/commands/verify.md:30 .claude/commands/verify.md:79 |
|
✅ Approved - No issues found |
Summary
/verifycommand for build verification/verify- SwiftLint only (fast)/verify full- SwiftLint + xcodebuild with optional background execution