Skip to content

Conversation

@buffalojoec
Copy link

Problem

The Address Lookup Table program has been migrated to an on-chain BPF program. It's time to remove it from the monorepo. This follows the same pattern as #5331.

Summary of Changes

It turns out the program isn't really used around the monorepo, so after #5645, we can just drop it!

@mergify
Copy link

mergify bot commented Apr 4, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@mergify
Copy link

mergify bot commented Apr 7, 2025

If this PR represents a change to the public RPC API:

  1. Make sure it includes a complementary update to rpc-client/ (example)
  2. Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @buffalojoec.

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.9%. Comparing base (905d041) to head (98711a0).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #5647     +/-   ##
=========================================
- Coverage    83.3%    82.9%   -0.4%     
=========================================
  Files         824      824             
  Lines      373859   375403   +1544     
=========================================
- Hits       311558   311503     -55     
- Misses      62301    63900   +1599     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@buffalojoec buffalojoec marked this pull request as ready for review April 9, 2025 12:44
@buffalojoec buffalojoec requested a review from a team as a code owner April 9, 2025 12:44
@buffalojoec buffalojoec requested a review from joncinque April 9, 2025 12:45
Copy link

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see it. LGTM

Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see all the red lines!

@buffalojoec buffalojoec merged commit e1c0607 into anza-xyz:master Apr 10, 2025
42 checks passed
@buffalojoec buffalojoec deleted the drop-alt branch April 10, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants