Remove use of stake_raise_minimum_delegation_to_1_sol in stake program

[pgarg66]

Problem

stake_raise_minimum_delegation_to_1_sol feature will not be used as part of the builtin stake program. But, this is causing a dependency on InvokeContext::get_feature_set(). This dependency needs to be removed as part of SVM repo migration.

Summary of Changes

Remove the feature usage from the builtin stake program.

Fixes #

[mergify]

If this PR represents a change to the public RPC API:

1. Make sure it includes a complementary update to rpc-client/ (example)
2. Open a follow-up PR to update the JavaScript client @solana/web3.js (example)

Thank you for keeping the RPC clients in sync with the server API @pgarg66.

[mergify]

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.9%. Comparing base (0d19c55) to head (4d2c5a8).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master    #5754     +/-   ##
=========================================
- Coverage    82.9%    82.9%   -0.1%     
=========================================
  Files         826      826             
  Lines      375390   375207    -183     
=========================================
- Hits       311525   311273    -252     
- Misses      63865    63934     +69     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[brooksprumo]

So if we merge this PR, there will be a chance that testnet halts. Since this feature gate is active, if some nodes run this version and some run the previous version, then they could disagree on if a new stake delegation succeeds or not.

Can you link to the SVM code that needs to remove the feature set lookup? I dunno if there's a chicken-and-egg problem here. I.e. we can't (shouldn't?) remove the code here without the bpf stake program going live first, but we also can't have the bpf stake program go live without removing the code here.

We may say it's OK to have testnet halt for the sake of simplicity, but I'm not sure who should make that call. Otherwise we'd need another feature gate to flip only testnet back to 1 lamport.

[pgarg66]

We want to remove FeatureSet from SVM. So, this function will need to be deleted.

agave/program-runtime/src/invoke_context.rs

Line 649 in b35f5be

pub fn get_feature_set(&self) -> &FeatureSet {

This is being called from a few builtin programs (including stake program) to check if a feature has been activated.

Is this particular feature on hold for MNB? If so, would it be deactivated on testnet?

[brooksprumo]

Yeah, stake_raise_minimum_delegation_to_1_sol isn't going to be activated on mnb in its current form. Trent suggested over in Discord that we deactivate this feature from testnet on the next testnet cluster restart. That'll allow us to then delete the code here.

[pgarg66]

This PR will not be backported. So it won't reach testnet anytime soon. Should we merge it on master? Or, would you rather wait for the feature to be deactivated before merging it?

[brooksprumo]

We still run edge builds against testnet though. If it were me, I'd wait until the feature was deactivated before merging.