feat : allow rpc mock to insert multiple duplicate requests
#5757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om Hashmap to Vec
Nagaprasadvr
force-pushed
the
rpc-mock-migrate-from-Hashmap-to-vec
branch
from
2107613 to
63ad411
Compare
kespinola
reviewed
Apr 11, 2025
Nagaprasadvr
force-pushed
the
rpc-mock-migrate-from-Hashmap-to-vec
branch
from
1aed3f8 to
40d5df4
Compare
added a test spec |
Nagaprasadvr
changed the title
feat : allow rpc mock to insert multiple duplicate requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently rpc mock uses Hashmap to populate RpcRequest and Json Response Value , but we cannot add multiple similar requests to this as its a Hashmap
Solution
Migrate from Hashmap to Vec<(RpcRequest, Value)> and impl the necessary methods and retain insert and remove methods