Fix - bpf_account_data_direct_mapping
#5764
Draft
+574
−694
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Summary of Changes
This PR has a carefully curated commit history and the commit messages explain each refactoring step. Please review commit by commit in order.
Open TODOs for the new
account_data_write_access_handler
:EXTEND_AND_WRITE_U64
oftest_program_sbf_realloc
to be flaky.Open TODOs for the logic which decides when and how much Vec capacity to zero:
Vec::capacity
and instead track an explicit additional field for each account.There is a new behavioral change in this patch, which I don't expect programs to depend on, but it needs to be tested / measured on MNB. See:
TEST_CPI_ACCOUNT_UPDATE_CALLER_GROWS_CALLEE_SHRINKS
.Feature Gate Issue: https://github.com/anza-xyz/feature-gate-tracker/issues/16