Single banking stage thread for votes

[apfitzge]

Problem

• We have 2 vote threads, one of them only does receiving. This seems to be an artifact of how we used to process transactions, rather than an ideal setup.

Summary of Changes

• Use a single vote thread to receive from both gossip & non-gossip channels
  • We could combine these channels, but leaving them separate allows us to track gossip vs non-gossip easily.
• Remove id from metrics, rename vote-only metrics to indicate they are only for the vote-thread

Fixes #

[apfitzge]

There will be a follow-up to this PR to remove all the interior mutability and locks that are in VoteStorage now that it is a single-thread. But that requires rewriting several of the loops.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.0%. Comparing base (c5edcfb) to head (7b7132a).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master    #5813     +/-   ##
=========================================
- Coverage    83.0%    83.0%   -0.1%     
=========================================
  Files         828      828             
  Lines      375510   375501      -9     
=========================================
- Hits       311857   311822     -35     
- Misses      63653    63679     +26     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.