Skip to content

Quic and Fetch break on seeing channel to sigverify disconnected #5815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 17, 2025
Merged

Quic and Fetch break on seeing channel to sigverify disconnected #5815

merged 4 commits into from
Apr 17, 2025

Conversation

apfitzge
Copy link

Problem

  • Quic and Fetch stages ignore their downstream channel being disconnected.
  • This can lead to validator staying up even if scheduler, sigverify go down

Summary of Changes

  • Break out of quic and fetch stage loops if sigverify is disconnected

Fixes #

@apfitzge
Copy link
Author

quic and fetch stages when seeing sigverify is dead:
image

@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.9%. Comparing base (9ede5cf) to head (e573344).
Report is 42 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5815   +/-   ##
=======================================
  Coverage    82.9%    82.9%           
=======================================
  Files         828      828           
  Lines      375794   375802    +8     
=======================================
+ Hits       311877   311907   +30     
+ Misses      63917    63895   -22
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@apfitzge apfitzge marked this pull request as ready for review April 16, 2025 13:20
@apfitzge apfitzge requested a review from bw-solana April 16, 2025 13:21
@bw-solana
Copy link

image

bw-solana
bw-solana reviewed Apr 16, 2025
View reviewed changes
streamer/src/streamer.rs Outdated
Err(TrySendError::Full(_)) => {
stats.num_packets_dropped.fetch_add(len, Ordering::Relaxed);
}
Err(TrySendError::Disconnected(b)) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why b?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why indeed?

@apfitzge apfitzge merged commit d7da5fb into anza-xyz:master Apr 17, 2025
30 checks passed
@apfitzge apfitzge deleted the kill_yourself_on_downstream_disconnect branch April 17, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bw-solana bw-solana bw-solana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apfitzge @codecov-commenter @bw-solana