Do not let gossip start with unset shred version #5837
Conversation
gregcusack
force-pushed
the
force-validator-to-start-with-set-shred-version
branch
from
b4d7b34 to
b3ac904
Compare
gregcusack
force-pushed
the
force-validator-to-start-with-set-shred-version
branch
2 times, most recently
from
9ba3095 to
83a7379
Compare
gregcusack
changed the title
gregcusack
changed the title
| if my_shred_version != 0 | ||
| && (node.shred_version() != 0 && node.shred_version() != my_shred_version) | ||
| { | ||
| if node.shred_version() != 0 && node.shred_version() != my_shred_version { |
There was a problem hiding this comment.
Can node shred_version be ever zero in the first place?
There was a problem hiding this comment.
not anymore since we switched spy to run on a valid shred version
ya not a bad idea. it's a little complicated since when we create a Node we don't know the shred version yet. We need to create the Node to download a snapshot at boot. but we don't need a valid shred version to download a snapshot. and then when we get the snapshot and genesis, we calculate the shred_version from genesis (if not passed in from cli). once we have the shred version, we update Node with the correct shred version. i will have to think about this one. |
Problem
We are in the process of removing the special
shred_version == 0case where validators can pull from any node if they set the shred version to 0Summary of Changes
Do not let gossip start with an unset shred version. Also, remove the special case check where we check to see if our shred version is 0.