Skip to content

agave-install: swap lazy_static import with std::sync::LazyLock #5850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025

Conversation

puhtaytow
Copy link

@puhtaytow puhtaytow commented Apr 16, 2025

Problem

We could have one import less by replacing lazy_static with standard library one.

Summary of Changes

Swapped lazy_static import by standard library.

Fixes #

@mergify mergify bot requested a review from a team April 16, 2025 18:03
@puhtaytow puhtaytow changed the title agave-install: welcome rust 1.80 / swap lazy_static! import with std::sync::LazyLock agave-install: welcome rust 1.80 / swap lazy_static import with std::sync::LazyLock Apr 16, 2025
@puhtaytow puhtaytow changed the title agave-install: welcome rust 1.80 / swap lazy_static import with std::sync::LazyLock agave-install: swap lazy_static import with std::sync::LazyLock Apr 16, 2025
@joncinque joncinque added the CI Pull Request is ready to enter CI label Apr 28, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Apr 28, 2025
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I think this makes sense to land.

Looks like CI is failing at the first step because the Cargo.lock file is not properly updated -- can you run ./scripts/cargo-for-all-lock-files.sh tree to update the lockfiles and commit those results?

@puhtaytow
Copy link
Author

Thanks for your contribution! I think this makes sense to land.

Looks like CI is failing at the first step because the Cargo.lock file is not properly updated -- can you run ./scripts/cargo-for-all-lock-files.sh tree to update the lockfiles and commit those results?

should be good now, thank you for help

@joncinque joncinque added the CI Pull Request is ready to enter CI label Apr 29, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Apr 29, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 83.0%. Comparing base (b45d086) to head (1b07a96).
Report is 127 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #5850     +/-   ##
=========================================
- Coverage    83.0%    83.0%   -0.1%     
=========================================
  Files         828      828             
  Lines      375773   375779      +6     
=========================================
- Hits       311947   311917     -30     
- Misses      63826    63862     +36     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@joncinque joncinque merged commit 45f66dc into anza-xyz:master Apr 29, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants