Skip to content

prevent overflow in port allocation logic for tests #5889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025

Conversation

alexpyattaev
Copy link

Problem

#5865 did not allow for sufficiently high number of nextest slots. CI machines have 64 cores => 64 slots and logic only worked correctly for ~59 slots causing sporadic test failures.

Summary of Changes

  • Constraint the number of concurrent tests < 64 (in case we get threadripper CI runners)
  • Fix allocation logic to not overflow with 64 slots
  • Reduce number of nodes in one gossip test from 50 to 40 (so we can fit in 47 20-port slices available per test process).

Fixes

Flakes like this one https://buildkite.com/anza/agave/builds/22593#01964750-dee6-49c7-8225-5a744952947f

@alexpyattaev alexpyattaev changed the title prevent overflow on test-runners prevent overflow in port allocation logic for tests Apr 19, 2025
@alexpyattaev alexpyattaev requested a review from bw-solana April 19, 2025 19:08
@alexpyattaev alexpyattaev marked this pull request as ready for review April 19, 2025 19:39
@alexpyattaev alexpyattaev requested a review from gregcusack April 19, 2025 19:39
@alexpyattaev alexpyattaev merged commit 1398508 into anza-xyz:master Apr 19, 2025
28 of 30 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.9%. Comparing base (86b229b) to head (a8de374).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #5889     +/-   ##
=========================================
- Coverage    82.9%    82.9%   -0.1%     
=========================================
  Files         830      830             
  Lines      376347   376347             
=========================================
- Hits       312282   312281      -1     
- Misses      64065    64066      +1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexpyattaev alexpyattaev removed the request for review from gregcusack April 19, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants