Skip to content

Feature - Remove loader v4 instruction deploy from source #5968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented Apr 24, 2025

Problem

The deploy from source instruction is unnecessary as its use case is covered by the copy instruction.

Summary of Changes

The CLI now sends the sequence:

  • Either create or retract program account
  • Set length of program account
  • Copy from buffer account
  • Deploy program account
  • Set length of buffer account to zero, effectively closing it and retrieving its funds

Feature Gate Issue: #78

@Lichtso Lichtso requested a review from a team as a code owner April 24, 2025 14:53
Copy link

mergify bot commented Apr 24, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso added the feature-gate Pull Request adds or modifies a runtime feature gate label Apr 24, 2025
@Lichtso Lichtso force-pushed the feature/remove_loader_v4_instruction_deploy_from_source branch from d1e29cf to 343c470 Compare April 24, 2025 16:37
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 41.53846% with 38 lines in your changes missing coverage. Please review.

Project coverage is 82.8%. Comparing base (9f99b75) to head (343c470).
Report is 33 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5968   +/-   ##
=======================================
  Coverage    82.8%    82.8%           
=======================================
  Files         830      830           
  Lines      377204   377143   -61     
=======================================
- Hits       312481   312474    -7     
+ Misses      64723    64669   -54     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Lichtso Lichtso added the v2.2 Backport to v2.2 branch label Apr 24, 2025
Copy link

mergify bot commented Apr 24, 2025

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate v2.2 Backport to v2.2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants