-
Notifications
You must be signed in to change notification settings - Fork 453
Feature - Remove loader v4 instruction deploy from source #5968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature - Remove loader v4 instruction deploy from source #5968
Conversation
…deploy_from_source in program-v4 CLI.
The Firedancer team maintains a line-for-line reimplementation of the |
d1e29cf
to
343c470
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5968 +/- ##
=======================================
Coverage 82.8% 82.8%
=======================================
Files 830 830
Lines 377204 377143 -61
=======================================
- Hits 312481 312474 -7
+ Misses 64723 64669 -54 🚀 New features to boost your workflow:
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Problem
The deploy from source instruction is unnecessary as its use case is covered by the copy instruction.
Summary of Changes
The CLI now sends the sequence:
Feature Gate Issue: #78