Added option to specify tpu addresses in vortexor #6116
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6116 +/- ##
=======================================
Coverage 82.9% 82.9%
=======================================
Files 842 842
Lines 377667 377684 +17
=======================================
+ Hits 313174 313192 +18
+ Misses 64493 64492 -1 🚀 New features to boost your workflow:
|
| tpu_fwd_address.port().saturating_sub(QUIC_PORT_OFFSET), | ||
| ); | ||
|
|
||
| for destination in destinations.read().unwrap().iter() { |
| @@ -92,6 +92,19 @@ pub struct Cli { | |||
| #[arg(long, value_parser = parse_port_range, value_name = "MIN_PORT-MAX_PORT", default_value = get_default_port_range())] | |||
| pub dynamic_port_range: (u16, u16), | |||
There was a problem hiding this comment.
How many dynamic ports does vortexor need? Maybe it could be easier to just make tpu_address and tpu_forwards_address required arguments and remove the dynamic_port_range argument?
There was a problem hiding this comment.
the dynamic_port_range is also used for client socket binds for rpc and websocket. We may add more sockets in the future such as for RPC service of the vortexor for subscription management.
There was a problem hiding this comment.
Oh I see, yes in this case it makes sense to have it to deconflict with agave. Also please make sure that defaults here are not the same as for agave itself, so if this is not provided we do not start accidentally binding on top of agave's default port range=)
lijunwangs
force-pushed
the
option_to_set_tpu_addresses
branch
from
d822eb7 to
274215e
Compare
Problem
Need to options to specify the TPU addresses in the vortexor so it is more deterministic to pair the vortexor and validator.
Summary of Changes
created the following options
--tpu-address
--tpu-forward-address
Also in the log show more friendly on how to pair the validator with the vortexor.
Fixes #