-
Notifications
You must be signed in to change notification settings - Fork 473
Feature - UpgradeableLoaderInstruction::ExtendProgramChecked
#6131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The Firedancer team maintains a line-for-line reimplementation of the |
e93ec72
to
435b3c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a fly-by review, the program logic looks great to me, just some small comments on the CLI and tests
8e7ef1f
to
c79ac7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of last things, and thanks for fixing up the tests, they look great!
c79ac7a
to
baba6ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the last bit from my side, then this is ready to go in!
edf3150
to
6f70d23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's just some lockfile changes to commit, then this is good to go!
e5fe7b1
to
042ef6f
Compare
042ef6f
to
f64f03c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6131 +/- ##
=========================================
- Coverage 82.9% 82.8% -0.1%
=========================================
Files 842 842
Lines 377680 377777 +97
=========================================
- Hits 313154 313142 -12
- Misses 64526 64635 +109 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks for addressing all the points!
See SIMD-0164.
Feature Gate Issue: TODO