Skip to content

Feature - UpgradeableLoaderInstruction::ExtendProgramChecked #6131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Lichtso
Copy link

@Lichtso Lichtso commented May 6, 2025

See SIMD-0164.

Feature Gate Issue: TODO

Copy link

mergify bot commented May 6, 2025

The Firedancer team maintains a line-for-line reimplementation of the
native programs, and until native programs are moved to BPF, those
implementations must exactly match their Agave counterparts.
If this PR represents a change to a native program implementation (not
tests), please include a reviewer from the Firedancer team. And please
keep refactors to a minimum.

@Lichtso Lichtso force-pushed the feature/extend_program_checked branch 6 times, most recently from e93ec72 to 435b3c6 Compare May 6, 2025 23:52
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a fly-by review, the program logic looks great to me, just some small comments on the CLI and tests

@Lichtso Lichtso force-pushed the feature/extend_program_checked branch 3 times, most recently from 8e7ef1f to c79ac7a Compare May 7, 2025 14:00
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of last things, and thanks for fixing up the tests, they look great!

@Lichtso Lichtso force-pushed the feature/extend_program_checked branch from c79ac7a to baba6ec Compare May 8, 2025 08:56
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the last bit from my side, then this is ready to go in!

@Lichtso Lichtso force-pushed the feature/extend_program_checked branch 2 times, most recently from edf3150 to 6f70d23 Compare May 8, 2025 10:29
Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's just some lockfile changes to commit, then this is good to go!

@Lichtso Lichtso force-pushed the feature/extend_program_checked branch 2 times, most recently from e5fe7b1 to 042ef6f Compare May 8, 2025 11:26
@Lichtso Lichtso force-pushed the feature/extend_program_checked branch from 042ef6f to f64f03c Compare May 8, 2025 11:28
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 6.07287% with 232 lines in your changes missing coverage. Please review.

Project coverage is 82.8%. Comparing base (0142ceb) to head (f64f03c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6131     +/-   ##
=========================================
- Coverage    82.9%    82.8%   -0.1%     
=========================================
  Files         842      842             
  Lines      377680   377777     +97     
=========================================
- Hits       313154   313142     -12     
- Misses      64526    64635    +109     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks for addressing all the points!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants