Adding an API to calculate storage size from the stored data lengths

[roryharr]

Problem

There is no API to calculate storage size of an account from the data length stored in account. This will be required for out dated account tracking.

Summary of Changes

Modified storage_size API to return data length instead.
Added API to convert from data length to storage_size.

See conversation here: https://github.com/anza-xyz/agave/pull/5950/files#r2069132522

Fixes #

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.9%. Comparing base (64e19be) to head (9523e72).
Report is 11 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master    #6132     +/-   ##
=========================================
- Coverage    82.9%    82.9%   -0.1%     
=========================================
  Files         842      842             
  Lines      377491   377525     +34     
=========================================
+ Hits       312968   312989     +21     
- Misses      64523    64536     +13     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[brooksprumo]

Idea looks good to me.

[HaoranYi]

Can we split the renaming of get_account_size function and the addition of the new function into separate PR?

[roryharr]

Can we split the renaming of get_account_size function and the addition of the new function into separate PR?

I don't think so in this case, because the definition of the function is changing.

[brooksprumo]

FYI, you can ignore the whole "this branch is out-of-date with the base branch" thing:

No need to update the base branch unless there are merge conflicts to resolve.

[roryharr]

FYI, you can ignore the whole "this branch is out-of-date with the base branch" thing:

No need to update the base branch unless there are merge conflicts to resolve.

Had to update it I think because of this:
https://buildkite.com/anza/agave/builds/23451#0196abc8-eb19-4ecc-b569-779fc95c49c5

Unless there is a better way of resolving issues like that.

It looks like someone removed a file that had an extra blank line, so it sees my change as having added an improperly formatted file .

[brooksprumo]

Had to update it I think because of this: https://buildkite.com/anza/agave/builds/23451#0196abc8-eb19-4ecc-b569-779fc95c49c5

Unless there is a better way of resolving issues like that.

It looks like someone removed a file that had an extra blank line, so it sees my change as having added an improperly formatted file .

Gotcha, yeah if the build on master is broken, gotta rebase (or merge) to fix. I personally always manually do the rebase on the cli, but I imagine GH "update branch" works too.

[brooksprumo]

If we don't have a valid reader here for Tiered Storage, I think that's a programmer bug. I'd recommend we do expect. Something like:

Suggested change

	.map_or(0, |reader| reader.calculate_stored_size(data_len)),
	.expect("tiered storage must be ready-only")
	.calculate_stored_size(data_len)

[roryharr]

Can see what i put. It took me a while to figure out why the reader was needed at all, so I put that in the expect message.