Skip to content

Removing unnecessary mutex in the bank client code #6133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

godmodegalactus
Copy link

Problem

There is a unnecessary mutex in bank client code, the transaction crossbeam sender locked behind the mutex.

Summary of Changes

Removing the mutex and cloning the sender instead is a better solution.

Fixes #

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.8%. Comparing base (a764514) to head (6a5a312).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6133   +/-   ##
=======================================
  Coverage    82.8%    82.8%           
=======================================
  Files         842      842           
  Lines      377392   377391    -1     
=======================================
  Hits       312832   312832           
+ Misses      64560    64559    -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@KirillLykov KirillLykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this client used anywhere these days?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants