Skip to content

Only collect and report per-program-timings when Trace is enabled #6140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tao-stones
Copy link

Problem

  • per-program-timings stats are always collected for each instruction executed, but only reported to metrics at trace level.
  • per-program-timings can be handy when debugging SVM to identify expensive programs, it should be kept.

Summary of Changes

  • move collecting and reporting behind log::log_enabled!(log::Level::Trace)

Fixes #6110

@tao-stones tao-stones requested a review from a team as a code owner May 7, 2025 14:12
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 82.9%. Comparing base (1f81db6) to head (828c5fc).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6140     +/-   ##
=========================================
- Coverage    82.9%    82.9%   -0.1%     
=========================================
  Files         842      842             
  Lines      377482   377488      +6     
=========================================
- Hits       312964   312954     -10     
- Misses      64518    64534     +16     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ProgramTimings tracking to eliminate unnecessary 200µs/block overhead
3 participants