Skip to content

solana-client tests to use dedicated port ranges #6149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

alexpyattaev
Copy link

Problem

Tests for solana-client kept using random ports to ensure maximal CI pain

Summary of Changes

Port to dedicated port ranges.

@alexpyattaev alexpyattaev requested a review from yihau May 7, 2025 20:53
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.9%. Comparing base (f7f2f5f) to head (31639a0).

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #6149     +/-   ##
=========================================
- Coverage    82.9%    82.9%   -0.1%     
=========================================
  Files         842      842             
  Lines      377663   377663             
=========================================
- Hits       313133   313100     -33     
- Misses      64530    64563     +33     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yihau
yihau previously approved these changes May 8, 2025
Copy link
Member

@yihau yihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! will approve again when you solve the cargo lock conflict :shipit:

@alexpyattaev
Copy link
Author

thank you! will approve again when you solve the cargo lock conflict :shipit:

Thank you, rebased.

@yihau yihau merged commit 5494638 into anza-xyz:master May 8, 2025
58 checks passed
@alexpyattaev alexpyattaev deleted the solana-client branch May 8, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants