alpenglow: add feature gate #6330
Conversation
you're too speedy haha, was going to post on slack in a bit. the plan was to slowly migrate the "non-alpenglow" related stuff from the private repo to agave, and then add the new alpenglow logic once it stabilizes. This involves the feature gate, and turning off poh / tower bft consensus related things behind the gate. wanted to get this out first so that non-consensus folks can have a chance to review and our foot is in the door for merge conflicts. Your point about rekeying makes sense, I can put a dummy key in for now and use the real one once we are closer to release |
AshwinSekar
force-pushed
the
alpenglow
branch
2 times, most recently
from
91d335f to
57cc2da
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6330 +/- ##
=======================================
Coverage 82.8% 82.8%
=======================================
Files 846 846
Lines 378217 378225 +8
=======================================
+ Hits 313234 313312 +78
+ Misses 64983 64913 -70 🚀 New features to boost your workflow:
|
| // Activate all features at genesis in development mode | ||
| for feature_id in FeatureSet::default().inactive() { | ||
| activate_feature(genesis_config, *feature_id); | ||
| if IS_ALPENGLOW || *feature_id != agave_feature_set::alpenglow::id() { |
There was a problem hiding this comment.
To confirm, the idea here is keep AG feature disabled by default but to also have a way to enable the gate for testing ?
There was a problem hiding this comment.
yeah exactly. it will take several dozen PRs before alpenglow is fully functional on master during which all our existing local cluster tests will be broken.
once functional we can remove this exception to enable the existing tests before we consider rekeying and releasing.
There was a problem hiding this comment.
Got it, that seems reasonable if we're going to incrementally move AG stuff over
Add new feature gate for alpenglow with a dummy key.
Once alpenglow stabilizes and is ready for activation, this will be rekeyed to a proper one.