Skip to content

v2.2: Add SBPFv1 tests to the CI pipeline (backport of #5126) #6344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2.2
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented May 28, 2025

Problem

There are three new SBPF versions already released in the platform tools that are compatible with the current validator configuration, but we do not test them actively in the CI.

Summary of Changes

  1. Modify the CI script to test SBPFv1
  2. Add a new command to the programs/sbf folder Makefile.
  3. Revamp tests that failed in SBPFv1.

This is an automatic backport of pull request #5126 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label May 28, 2025
@mergify mergify bot requested a review from a team as a code owner May 28, 2025 20:44
@mergify mergify bot added the conflicts label May 28, 2025
Copy link
Author

mergify bot commented May 28, 2025

Cherry-pick of b704875 has failed:

On branch mergify/bp/v2.2/pr-5126
Your branch is up to date with 'origin/v2.2'.

You are currently cherry-picking commit b704875fb.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   ci/test-stable.sh
	modified:   programs/sbf/Makefile
	modified:   programs/sbf/rust/invoke/Cargo.toml
	modified:   programs/sbf/rust/invoke/src/lib.rs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   programs/sbf/tests/programs.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@LucasSte LucasSte force-pushed the mergify/bp/v2.2/pr-5126 branch from c3d59a5 to 6564133 Compare May 28, 2025 20:54
@LucasSte
Copy link

Agave v2.2 supports new SBPF versions and we may enable them in testnet. These versions are thoroughly tested in the main branch, but I have a couple of PRs (which need to be merged in order) to enable tests for them in v2.2.

This PR and the other ones that will follow do not have any functional change, besides tweaking with CI commands and some tests adaptations. (#6264 (comment))

The previous PRs in this chain were #6264 and #6273.

@LucasSte
Copy link

The CI error needs #6357 to be fixed.

* Add SBPFv1 to the CI pipeline

* Tune instruction count

* Check upper bound instead of fixed number of instructions

* Verify zeroed stack with dynamic stack frames

* Use constants to estimate length of zeroed bytes

* Remove comment

(cherry picked from commit b704875)
@LucasSte LucasSte force-pushed the mergify/bp/v2.2/pr-5126 branch from 6564133 to d7f7742 Compare June 4, 2025 13:37
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.4%. Comparing base (76a375b) to head (d7f7742).

Additional details and impacted files
@@           Coverage Diff           @@
##             v2.2    #6344   +/-   ##
=======================================
  Coverage    83.4%    83.4%           
=======================================
  Files         807      807           
  Lines      373380   373380           
=======================================
+ Hits       311556   311600   +44     
+ Misses      61824    61780   -44     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucasSte LucasSte requested a review from Lichtso June 4, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants