Fix misfiring 'solana-sdk disallowed' check #6347
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you probably wanna just drop the check altogether for invalidator? |
I can but I don't see why. Can you elaborate please? I already removed all invalidator-specific instances of solana-sdk. So the check is useful not to re-introduce them there either going forward and stay consistent with Agave. I don't need to upstream this change though. I already applied it there. So I'm not blocked by this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During upstream sync CI run in invalidator, 'ci/sanity-test.sh' is misfiring on a solana-sdk reference from the disallowed macros in 'clippy.toml'.
Summary of Changes
Exclude 'clippy.toml' from the solana-sdk disallowed check.