Skip to content

Fix misfiring 'solana-sdk disallowed' check #6347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fkouteib
Copy link

Problem

During upstream sync CI run in invalidator, 'ci/sanity-test.sh' is misfiring on a solana-sdk reference from the disallowed macros in 'clippy.toml'.

Summary of Changes

Exclude 'clippy.toml' from the solana-sdk disallowed check.

@fkouteib fkouteib requested a review from t-nelson May 29, 2025 05:51
@t-nelson
Copy link

you probably wanna just drop the check altogether for invalidator?

@fkouteib
Copy link
Author

you probably wanna just drop the check altogether for invalidator?

I can but I don't see why. Can you elaborate please? I already removed all invalidator-specific instances of solana-sdk. So the check is useful not to re-introduce them there either going forward and stay consistent with Agave. I don't need to upstream this change though. I already applied it there. So I'm not blocked by this.

@fkouteib fkouteib closed this May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants