Skip to content

Conversation

@alexpyattaev
Copy link

@alexpyattaev alexpyattaev commented Dec 18, 2025

Problem

we do the xdp init steps that requires capabilities quite late in validator process start up. we've already spawned many threads, which will have inherited caps that they do not need, posing security risk.

Summary of Changes

  • Move some of the init steps to the early stages in validator startup to "fail fast".
  • This should not change any of the core functionality.
  • This does not improve security but does improve the startup UX & opens path for further refactoring.
  • Follow-up PR will address the loading of eBPF program

See also: #9133

@alexpyattaev alexpyattaev force-pushed the xdp_fetch_device_refactor branch from 348a53c to 0b4b776 Compare December 18, 2025 21:14
@alexpyattaev alexpyattaev changed the title determine NetworkDevice to use for xdp early XDP: determine NetworkDevice to use early in startup Dec 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.6%. Comparing base (ef5d037) to head (1a18408).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #9649     +/-   ##
=========================================
- Coverage    82.6%    82.6%   -0.1%     
=========================================
  Files         902      903      +1     
  Lines      323498   323498             
=========================================
- Hits       267306   267304      -2     
- Misses      56192    56194      +2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexpyattaev alexpyattaev force-pushed the xdp_fetch_device_refactor branch from 0b4b776 to 47205f5 Compare December 19, 2025 10:48
@alexpyattaev alexpyattaev force-pushed the xdp_fetch_device_refactor branch from 47205f5 to 4aafe46 Compare December 19, 2025 11:03
@alexpyattaev alexpyattaev force-pushed the xdp_fetch_device_refactor branch from a9b426c to 0a86585 Compare December 19, 2025 11:47
@alexpyattaev alexpyattaev marked this pull request as ready for review December 19, 2025 20:46
@alexpyattaev alexpyattaev requested a review from a team as a code owner December 19, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants