-
Notifications
You must be signed in to change notification settings - Fork 137
Feat: Persistent selected wallet account context provider #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat: Persistent selected wallet account context provider #1154
Conversation
|
|
Hi @mcintyre94 I have done the selected wallet context provider. And I am trying to unit test for that but I find the existing tests are being written using react-test-renderer which is deprecated. Should I write the test for this using react-test-renderer or react-testing-library? I think its better to start writing in react-testing-library as its gonna be migrated to this at some point. |
|
Thanks @ningthoujamSwamikumar, I'll try to review this soon. In terms of testing I'm happy to use BTW a useful validation check for this would be using it in the react app :) |
BundleMonFiles updated (3)
Unchanged files (133)
Total files change +2.06KB +0.53% Final result: ✅ View report in BundleMon website ➡️ |
Problem
The biggest piece of complexity in the example react-app is about persisting the selected wallet. And while wallet-standard allows an app to be connected to multiple wallets/accounts per wallet, in practice most apps will want to have some context about the currently active account, ie the UiWalletAccount to pass to hooks like useSignAndSendTransaction.
Summary of Changes
Fixes #1148