Skip to content

Issue 20: local-cluster MCP integration test (depends on all MCP PRs)#45

Open
aeyakovenko wants to merge 311 commits intoanza-xyz:masterfrom
aeyakovenko:issue-20-mcp-local-cluster-test
Open

Issue 20: local-cluster MCP integration test (depends on all MCP PRs)#45
aeyakovenko wants to merge 311 commits intoanza-xyz:masterfrom
aeyakovenko:issue-20-mcp-local-cluster-test

Conversation

@aeyakovenko
Copy link
Copy Markdown

Summary

This PR delivers Issue anza-xyz#20 (local-cluster MCP integration test) on top of the full MCP implementation stack.

It is intentionally integration-heavy and should be reviewed as depending on all MCP implementation PRs (#24 through #43).

Dependency stack

This PR depends on all prior MCP PRs:

What is included

  • MCP local-cluster integration test updates (test_local_cluster_mcp_produces_blockstore_artifacts):
    • explicit MCP feature activation timing and readiness checks
    • reduced blockstore scanning overhead with bounded slot windows and focused probes
    • richer runtime diagnostics (submitted tx count, rooted vs working slots, role diagnostics)
    • environment-aware strictness gate:
      • default mode: non-flaky CI-safe behavior with diagnostic skip
      • strict mode: MCP_LOCAL_CLUSTER_STRICT=1 enforces hard failure if MCP artifacts are absent
  • MCP proposer dispatch behavior fix:
    • do not drop empty MCP payload slots in proposer dispatch
  • MCP reconstruction persistence fix:
    • persist empty execution output when reconstruction is valid but yields no executable transactions
    • dedicated unit test coverage for this behavior

Validation

Executed on this branch:

  • cargo test -p solana-core test_maybe_persist_reconstructed_execution_output_marks_empty_output -- --nocapture
  • cargo test -p solana-core test_refresh_vote_gate_input_populates_slot_input_from_consensus_block -- --nocapture
  • cargo test -p solana-turbine test_maybe_dispatch_mcp_shreds_removes_complete_slot_payload_state -- --nocapture
  • cargo test --manifest-path local-cluster/Cargo.toml test_local_cluster_mcp_produces_blockstore_artifacts -- --nocapture

Notes

  • plan.md remains the source of truth on master; no additional plan changes are required by this delta.

# Conflicts:
#	ledger/src/shred/mcp_shred.rs
#	plan.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant