Use 3.0 crates and 2.0 SPL interfaces #155
Conversation
buffalojoec
left a comment
buffalojoec
left a comment
There was a problem hiding this comment.
Cool, thanks for putting this together! Just some comments about a few things.
fuzz/fixture/src/context.rs
Outdated
| compute_budget: value.compute_budget.map(Into::into).unwrap_or_else(|| { | ||
| #[cfg(feature = "simd-0296")] | ||
| #[cfg(feature = "simd-0268")] | ||
| { | ||
| ComputeBudget::new_with_defaults(true) | ||
| } | ||
| #[cfg(not(feature = "simd-0296"))] | ||
| #[cfg(not(feature = "simd-0268"))] | ||
| { |
There was a problem hiding this comment.
Ah, I see the problem. So this should be the only spot we need this feature flag, right?
Since these conversions happen when the fuzz API reads from a fixture, we really need to use the value in the feature set to flip this boolean.
I think you can just evaluate the feature set first here, and then look up whether or not the feature is active to plumb the boolean through the compute budget conversion. We probably have to move off of From for ComputeBudget and use a free function. That's no biggie.
There was a problem hiding this comment.
Makes sense, free function incoming.
buffalojoec
left a comment
buffalojoec
left a comment
There was a problem hiding this comment.
Almost there! Thanks again.
buffalojoec
left a comment
buffalojoec
left a comment
There was a problem hiding this comment.
Thanks for cranking this out!
2 participants
Updates Mollusk to use:
simd-0268feature for SIMD-0268max_instruction_stack_depthwhen constructingComputeBudget