harness: Add program with loader helper#182
Merged
buffalojoec merged 3 commits intoanza-xyz:mainfrom Dec 1, 2025
Merged
Conversation
febo
force-pushed
the
add-program-with-loader
branch
from
ec11fe1 to
b46743c
Compare
| /// | ||
| /// If you intend to CPI to a program, this is likely what you want to use. | ||
| pub fn add_program_with_elf_and_loader( | ||
| pub fn add_program_with_loader_and_elf( |
Contributor
There was a problem hiding this comment.
maybe it worth to change the order of arguments to the function also to not confuse naming and how to use?
Collaborator
Author
There was a problem hiding this comment.
Good catch - updated.
buffalojoec
approved these changes
Dec 1, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While there are a couple of
add_program*helpers, there is none that adds a program under theDEFAULT_LOADER_KEY. This requires to always have to specify a loader when adding additional programs – see here.Solution
Refactor the helpers to include 3 different variations:
add_programadd_program_with_loaderadd_program_with_loader_and_elf