Skip to content

Comments

feat: Dump a register trace disassembly if SBF_TRACE_DISASSEMBLE is set#199

Merged
buffalojoec merged 3 commits intoanza-xyz:mainfrom
procdump:dump_trace
Feb 20, 2026
Merged

feat: Dump a register trace disassembly if SBF_TRACE_DISASSEMBLE is set#199
buffalojoec merged 3 commits intoanza-xyz:mainfrom
procdump:dump_trace

Conversation

@procdump
Copy link
Contributor

@procdump procdump commented Feb 16, 2026

What's changed

Dump a register trace disassembly if requested by user taking advantage of the API in solana-sbpf.

@procdump
Copy link
Contributor Author

procdump commented Feb 16, 2026

cc @buffalojoec

@procdump procdump mentioned this pull request Feb 16, 2026
Merged
@procdump procdump marked this pull request as draft February 19, 2026 08:00
@procdump procdump force-pushed the dump_trace branch 2 times, most recently from e95f95d to 3c5012d Compare February 19, 2026 08:25
@procdump
Make SBF_TRACE_DISASSEMBLE a configurable field on DefaultRegisterTra…
c6301c0 
…cingCallback

Read the environment variable once at initialization instead of
on every handler invocation, consistent with how SBF_TRACE_DIR is handled.
@procdump procdump marked this pull request as ready for review February 19, 2026 08:37
buffalojoec
buffalojoec reviewed Feb 19, 2026
View reviewed changes
Copy link
Collaborator

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Mind just updating the section in the README with the new field and variable?

@procdump procdump requested a review from buffalojoec February 19, 2026 09:42
@buffalojoec
Copy link
Collaborator

buffalojoec commented Feb 19, 2026

@procdump this is a breaking change, so do you want me to wait to publish until you've landed any more register tracing changes?

@buffalojoec buffalojoec added the breaking Breaking change label Feb 19, 2026
@procdump
Copy link
Contributor Author

procdump commented Feb 19, 2026

@procdump this is a breaking change, so do you want me to wait to publish until you've landed any more register tracing changes?

I'm currently preparing the sbpf-debugger feature contribution. It also has some breaking changes to the API, yet I can't fully submit it because mollusk is still tied to 3.1.x and the necessary debugger PRs actually landed in agave master 4.x. However, I can split the debugger feature into smaller ones moving out code that also pertain to the register tracing changes. Does this sound reasonable to you? With this approach we can reduce the breaking versions I believe.

@buffalojoec
Copy link
Collaborator

buffalojoec commented Feb 20, 2026

I'm currently preparing the sbpf-debugger feature contribution. It also has some breaking changes to the API, yet I can't fully submit it because mollusk is still tied to 3.1.x and the necessary debugger PRs actually landed in agave master 4.x. However, I can split the debugger feature into smaller ones moving out code that also pertain to the register tracing changes. Does this sound reasonable to you? With this approach we can reduce the breaking versions I believe.

Yeah, I don't mind many subsequent changes, but I'd prefer to release once we have all of them in. I can release earlier if you need to use this change, though.

@buffalojoec buffalojoec merged commit 16e95bc into anza-xyz:main Feb 20, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@buffalojoec buffalojoec buffalojoec approved these changes

Assignees

No one assigned

Labels

breaking Breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@procdump @buffalojoec