Use InstructionView from Solana SDK
#122
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febo
force-pushed
the
febo/solana-instruction-view
branch
from
c3e49e7 to
ffa484b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, pinocchio defines its own (zero-copy)
InstructionandAccountMetastructs. The name clash makes it confusing to write code that interacts with both Solana SDK and pinocchio.Solution
Use the types from the new
solana-instruction-viewcrate in Solana SDK instead. While this is a breaking change since the type has a different name, it has the same characteristics of the current types, so there is no loss of efficiency.Note that this change removes the need of having the instruction related code in the main pinocchio crate – instead, client code can import
solana-instruction-viewdirectly to use the types.