Adds unchecked calls to system program #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redmannequin
force-pushed
the
add-unchecked-calls-to-system-program
branch
from
96fb12e to
60d4104
Compare
redmannequin
force-pushed
the
add-unchecked-calls-to-system-program
branch
from
60d4104 to
755df53
Compare
redmannequin
commented
Apr 14, 2025
| /// callee, then Rust's aliasing rules will be violated and cause undefined | ||
| /// behavior. | ||
| pub unsafe fn invoke_signed_access_unchecked<const ACCOUNTS: usize>( | ||
| instruction: &Instruction, |
There was a problem hiding this comment.
It could be worth creating a FixedInstruction variant that takes in const generic for the account metas length. constraining the number of accounts to account metas at type level/compile time.
redmannequin
changed the title
redmannequin
commented
Apr 15, 2025
| /// | ||
| /// `InvokeParts` is a helper structure that encapsulates all parts of a Solana instruction call, | ||
| /// including the program ID, account references, account metadata, and the instruction data payload. | ||
| pub struct InvokeParts<'a, const ACCOUNTS: usize, Data> { |
There was a problem hiding this comment.
I don't think this should live in the SDK -- perhaps a pinocchio-client-helpers crate?
But for now let's just copy the trait + types into the other clients and see if it generalizes well?
There was a problem hiding this comment.
we'll need at least one more InstructionData for slices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The predefined solana programs(
system,token, etc.) only exposeinvokeandinvoke_signedcalls. It would be nice to haveunsafecalls as well.Solution
Invoketrait that contains default implementations for 'invoke' and 'invoke_signed' as well as for the unsafe counter parts.Invokeis auto implemented for any type that can convert intoInvokePartswhich contains all the necessary information to run an invoke call.From<T> for InvokePartsfor all instructionsNOTES