Skip to content

Unsafe instruction context constructor #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2025
Merged

Unsafe instruction context constructor #133

merged 1 commit into from
Apr 20, 2025

Conversation

febo
Copy link
Collaborator

@febo febo commented Apr 15, 2025

Problem

Currently the InstructionContext::new constructor performs unsafe operations but it is not "qualified" as unsafe.

Solution

Deprecate the current InstructionContext::new and add an unsafe variant InstructionContext::new_unchecked.

@febo febo requested a review from joncinque April 15, 2025 07:58
@febo febo merged commit c647c62 into main Apr 20, 2025
9 checks passed
@febo febo deleted the febo/lazy-unsafe branch April 20, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joncinque joncinque Awaiting requested review from joncinque

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@febo