Add create_with_seed #161
Merged
Add create_with_seed #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
febo
reviewed
May 28, 2025
sdk/pinocchio/src/pubkey.rs
Outdated
| } | ||
|
|
||
| /// Derive a Pubkey from another Pubkey, seed, and a program id. | ||
| #[inline] |
Collaborator
There was a problem hiding this comment.
This one can always be inlined.
febo
reviewed
May 28, 2025
febo
reviewed
May 28, 2025
febo
reviewed
May 28, 2025
febo
reviewed
Jul 10, 2025
febo
reviewed
Jul 10, 2025
ilya-bobyr
reviewed
Jul 10, 2025
ilya-bobyr
reviewed
Jul 14, 2025
Contributor
ilya-bobyr
left a comment
ilya-bobyr
left a comment
There was a problem hiding this comment.
Looks good to me.
But better if @febo would take a look again as well.
febo
approved these changes
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
create_with_seedfunction. It mimics the same function fromsolana-pubkey, except thatseedis&[u8]instead of&str.