log: Add unsafe to Log trait #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
approved these changes
Jul 1, 2025
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
Logtrait has memory safety implications in its implementation, but it is not marked asunsafe. The implementation must ensure that the value returned by any of the methods correctly reflects the actual number of bytes written to the buffer. Returning a value greater than the number of bytes written to the buffer will result in undefined behavior, since it will lead to reading uninitialized memory from the buffer.Solution
Add
unsafetoLogtrait to make it explicit that the trait has to be carefully implemented.cc: @d0nutptr