-
Notifications
You must be signed in to change notification settings - Fork 165
feat : add token-2022 core ixs and state
#190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : add token-2022 core ixs and state
#190
Conversation
6f0312e to
e2f66e6
Compare
feat : add token-2022 core ixs and state
|
If we can get that for the next version, it could be great. |
febo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a few more nits.
4a43c2a to
cc1a3eb
Compare
cc1a3eb to
c30d8d7
Compare
febo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, a final nit and this can go in.
|
@Nagaprasadvr Could you rebase the PR so it gets the spellcheck in CI? |
c2f32ac to
a6584d1
Compare
done ser @febo |
ananas-block
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looking forward to be able to use flexible token program ids!
Random idea, token22 and token instructions code look identical, save for the flexible token_program pubkey, and if so could be unified. The token22 instruction code could be wrapped or reexported in token/src/instructions.
Yeah, I think the idea is to unify them under the Token-22 one since this is a superset of the token instructions. |
Just missing passing CI. You can check how the spelling was fixed on the token one. |
a6584d1 to
556a043
Compare
@febo i have fixed the docs |
556a043 to
2b0f772
Compare
|
is there any blocker to this getting merged soon , if so would love to help out, since we are using pinocchio rn and we have code dealing with t22 program not sure if there is any recommended alternative to use until its officially merged. |
febo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good – thanks!
@febo