Skip to content

Conversation

@Nagaprasadvr
Copy link
Contributor

@Nagaprasadvr Nagaprasadvr commented Jul 8, 2025

  1. use u64::from_le_bytes to read u64 value instead of read_unaligned
  2. rename from_bytes to from_bytes_unchecked
  3. update docs

@Nagaprasadvr Nagaprasadvr force-pushed the cleanup-token-crate branch from d11d7d8 to 4880fbe Compare July 8, 2025 04:01
@Nagaprasadvr Nagaprasadvr force-pushed the cleanup-token-crate branch from 4880fbe to 78c62d8 Compare July 10, 2025 03:46
@Nagaprasadvr Nagaprasadvr requested review from febo and ilya-bobyr July 10, 2025 03:47
Copy link
Contributor

@ilya-bobyr ilya-bobyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
As I'm not part of the SDK team, it would probably be better if the final approval comes from @febo or someone else from the SDK team.

Copy link
Collaborator

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great – thanks!

@febo febo merged commit 1b9a591 into anza-xyz:main Jul 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants